[Branch 2.7] Avoid potentially blocking calls to metadata in PersistentTopic#getMessageTTL#16899
Merged
codelipenghui merged 1 commit intoapache:branch-2.7from Aug 3, 2022
Merged
Conversation
Contributor
Author
|
/pulsarbot run-failure-checks |
Contributor
Author
codelipenghui
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is part of work of cherry-pick #12340 to branch 2.7
There is a concurrent issue when updating namespace TTL, causing
AdminApiTest#testTopicStatsLastExpireTimestampForSubscriptionfails periodically.The root cause is that in
NamespacesBase#internalSetNamespaceMessageTTL:policiesCache().invalidateto disable the cache.But between Step A and B,
ZooKeeperDataCachewill receive a data change event, and new data ofpoliciesCachewill be reloaded inZooKeeperDataCache#reloadCache. So this reloaded data will invalidated in Step B.And in
PersistentTopic#onPoliciesUpdate(triggered by Step A) won't be able to get policy data withpoliciesCache().getDataIfPresent, socheckMessageExpiryis skipped and results inAdminApiTest#testTopicStatsLastExpireTimestampForSubscriptionfailure.Modifications
Remove
policiesCache().invalidatein Step B.Verifying this change
Documentation
Check the box below or label this PR directly.
doc-not-neededBug fix