[improve][test] Avoid hacky modify static final field#17005
Merged
Technoboy- merged 1 commit intoapache:masterfrom Aug 9, 2022
Merged
[improve][test] Avoid hacky modify static final field#17005Technoboy- merged 1 commit intoapache:masterfrom
Technoboy- merged 1 commit intoapache:masterfrom
Conversation
Signed-off-by: tison <wander4096@gmail.com>
hezhangjian
approved these changes
Aug 9, 2022
codelipenghui
approved these changes
Aug 9, 2022
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
@Technoboy- if we don't cherry-pick to 2.11, perhaps we don't pick to 2.10 also? This is not a bugfix. The only reason I can see to pick to reduce code conflict. |
Technoboy-
pushed a commit
that referenced
this pull request
Aug 10, 2022
Technoboy-
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Aug 16, 2022
Contributor
|
This change depends on #15238, which is not included in branch-2.10, so drop |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #16912
doc-not-neededcc @shoothzj @eolivelli