[cleanup][broker] Follow up on #16968 to restore some behavior in PersistentDispatcherMultipleConsumers class #17018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
approved these changes
Aug 9, 2022
RobertIndie
approved these changes
Aug 9, 2022
This was referenced Aug 10, 2022
michaeljmarshall
approved these changes
Aug 10, 2022
This was
linked to
issues
Aug 10, 2022
codelipenghui
approved these changes
Aug 10, 2022
mattisonchao
commented
Aug 10, 2022
.../java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Outdated
Show resolved
Hide resolved
mattisonchao
changed the title
lhotari
requested changes
Aug 10, 2022
.../java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Outdated
Show resolved
Hide resolved
lhotari
approved these changes
Aug 10, 2022
mattisonchao
changed the title
Technoboy-
pushed a commit
that referenced
this pull request
Aug 10, 2022
…sistentDispatcherMultipleConsumers class (#17018)
tisonkun
reviewed
Aug 10, 2022
.../java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java
Show resolved
Hide resolved
mattisonchao
added
release/2.9.2
release/2.10.2
release/2.8.5
release/2.9.4
cherry-picked/branch-2.8
Technoboy-
pushed a commit
to merlimat/pulsar
that referenced
this pull request
Aug 16, 2022
…in PersistentDispatcherMultipleConsumers class (apache#17018)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Aug 16, 2022
…in PersistentDispatcherMultipleConsumers class (apache#17018) (cherry picked from commit abff91f)
nodece
pushed a commit
to nodece/pulsar
that referenced
this pull request
Sep 10, 2024
…in PersistentDispatcherMultipleConsumers class (apache#17018) (cherry picked from commit abff91f) Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #16968 made changes to the logic how sendInProgress field is set in
PersistentDispatcherMultipleConsumersclass and a decision was made in a post-merge review to revert the changes.Modifications
Verifying this change
Documentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)