[fix][flaky-test]ConsumedLedgersTrimTest #17116

poorbarcode · 2022-08-16T12:24:02Z

Fixes

Motivation

pulsar/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ConsumedLedgersTrimTest.java

Lines 145 to 150 in 4d7b1ac

    
           restartBroker(); 
        
           // force load topic 
        
           pulsar.getAdminClient().topics().getStats(topicName); 
        
           MessageId messageIdAfterRestart = pulsar.getAdminClient().topics().getLastMessageId(topicName); 
        
           LOG.info("lastmessageid " + messageIdAfterRestart); 
        
           assertEquals(messageIdAfterRestart, messageIdBeforeRestart);

In addition to calling internalTrimLedgers directly in this unit test, the Broker also has scheduled tasks consumedLedgersMonitor calling internalTrimLedgers.

(High light)See the code above, If consumedLedgersMonitor call internalTrimLedgers before line:148:
the command topics.getLastMessageId will return -1:-1:-1, then the #11145 #10380 occurs.

pulsar/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ConsumedLedgersTrimTest.java

Lines 152 to 161 in 4d7b1ac

    
           persistentTopic = (PersistentTopic) pulsar.getBrokerService().getOrCreateTopic(topicName).get(); 
        
           managedLedgerConfig = persistentTopic.getManagedLedger().getConfig(); 
        
           managedLedgerConfig.setRetentionSizeInMB(-1); 
        
           managedLedgerConfig.setRetentionTime(1, TimeUnit.SECONDS); 
        
           managedLedgerConfig.setMaxEntriesPerLedger(1); 
        
           managedLedgerConfig.setMinimumRolloverTime(1, TimeUnit.MILLISECONDS); 
        
           managedLedger = (ManagedLedgerImpl) persistentTopic.getManagedLedger(); 
        
           // now we have two ledgers, the first is expired but is contains the lastMessageId 
        
           // the second is empty and should be kept as it is the current tail 
        
           Assert.assertEquals(managedLedger.getLedgersInfoAsList().size(), 2);

(High light)See the code above, If consumedLedgersMonitor call internalTrimLedgers before line:161:
the command managedLedger.getLedgersInfoAsList().size() will return 1, then the #17044 occurs.

Modifications

Fix flaky test: Make internalTrimLedgers never trigger by consumedLedgersMonitor before consumedLedgersMonitor is triggered manually: disabled policy retention.

pulsar/pulsar-broker/src/test/java/org/apache/pulsar/broker/service/ConsumedLedgersTrimTest.java

Lines 94 to 99 in 4d7b1ac

    
           for (int i = 0; i < msgNum; i++) { 
        
               Message<byte[]> msg = consumer.receive(2, TimeUnit.SECONDS); 
        
               assertNotNull(msg); 
        
               consumer.acknowledge(msg); 
        
           } 
        
           Assert.assertEquals(managedLedger.getLedgersInfoAsList().size(), msgNum / 2);

Try to solve another hidden Falky test: See the code above, I think line:99 may be flaky, because we can't guarantee that consumedLedgersMonitor --> internalTrimLedgers will be executed later than line:99, so delete line:99