[fix][flaky-test]BrokerInterceptorTest.testProducerCreation #17159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Aug 18, 2022
Contributor
codelipenghui
left a comment
codelipenghui
left a comment
There was a problem hiding this comment.
Yes, I think you found the root cause.
codelipenghui
changed the title
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Technoboy-
pushed a commit
that referenced
this pull request
Aug 19, 2022
Jason918
pushed a commit
that referenced
this pull request
Sep 4, 2022
(cherry picked from commit 84968e8)
congbobo184
pushed a commit
that referenced
this pull request
Nov 30, 2022
(cherry picked from commit 84968e8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16516
Motivation
Client will receive response of
cmd-subscribebefore executedInterceptor().consumerCreated()pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Lines 1100 to 1102 in 3c3ec49
Same thing with
ProducerCreation.Modifications
Use the
counterto determine if the task is complete.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)