Skip to content

Conversation

@gaozhangmin
Copy link
Contributor

@gaozhangmin gaozhangmin commented Aug 19, 2022

Motivation

Fix flaky test testBacklogNoDelayedForPartitionedTopic

Error:  testBacklogNoDelayedForPartitionedTopic(org.apache.pulsar.broker.admin.AdminApi2Test)  Time elapsed: 2.24 s  <<< FAILURE!
  java.lang.AssertionError: expected [5] but found [6]
  	at org.testng.Assert.fail(Assert.java:99)
  	at org.testng.Assert.failNotEquals(Assert.java:1037)
  	at org.testng.Assert.assertEqualsImpl(Assert.java:140)
  	at org.testng.Assert.assertEquals(Assert.java:122)
  	at org.testng.Assert.assertEquals(Assert.java:797)
  	at org.testng.Assert.assertEquals(Assert.java:807)
  	at org.apache.pulsar.broker.admin.AdminApi2Test.testBacklogNoDelayedForPartitionedTopic(AdminApi2Test.java:1627)
  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
  	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
  	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
  	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
  	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
  	at org.testng.internal.InvokeMethodRunnable.runOne(InvokeMethodRunnable.java:45)
  	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:73)
  	at org.testng.internal.InvokeMethodRunnable.call(InvokeMethodRunnable.java:11)
  	at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
  	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
  	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
  	at java.base/java.lang.Thread.run(Thread.java:833)

Modifications

Message is not added to delayed priorityQueue immediately after send.

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions
Copy link

@gaozhangmin Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@gaozhangmin gaozhangmin force-pushed the flaky-test-testBacklogNoDelayedForPartitionedTopic branch from d49cd62 to e5ce0b6 Compare August 19, 2022 12:48
@gaozhangmin
Copy link
Contributor Author

/pulsarbot run-failure-checks

@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Aug 21, 2022
@Technoboy- Technoboy- merged commit 1faf497 into apache:master Aug 21, 2022
Jason918 pushed a commit that referenced this pull request Sep 4, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Sep 16, 2022
…pic (apache#17180)

(cherry picked from commit 1faf497)
(cherry picked from commit 4c6417a)
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 8, 2022
congbobo184 pushed a commit that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants