[fix][admin] Fix unWrap Exception when getPoliciesAsync #17249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
Aug 24, 2022
tisonkun
reviewed
Aug 24, 2022
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
@wenbingshen can you share a real-world failure instance with stacktrace?
IIUC ComplateableFuture#exceptionally should take the inner exception instead of a CompletionException. If so, it's likely something wrong from the dependent future.
tisonkun
approved these changes
Aug 24, 2022
Member
tisonkun
left a comment
tisonkun
left a comment
There was a problem hiding this comment.
Sorry. The exception should be always CompletionException.
LGTM.
Technoboy-
changed the title
Technoboy-
added
type/bug
Technoboy-
approved these changes
Aug 24, 2022
Member
Author
|
/pulsarbot run-failure-checks |
2 similar comments
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
/pulsarbot run-failure-checks |
|
@wenbingshen Please provide a correct documentation label for your PR. |
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Aug 26, 2022
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Aug 29, 2022
Jason918
pushed a commit
that referenced
this pull request
Sep 4, 2022
(cherry picked from commit 70661e3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifications
getPoliciesAsyncmay return an exception wrapped asCompletionExceptionDocumentation
doc-not-needed