[fix][broker]fix catching ConflictException when update topic partition

[TakaHiR07]

Motivation

A fix for #17251. There is an error when handling ConflictException.

The previous unittest can not approve it, so I add another test.

Modifications

ex.getCause() -> ex

add test.

Verifying this change

• Make sure that the change passes the CI checks.

Documentation

Check the box below or label this PR directly.

Need to update docs?

• doc-required
  (Your PR needs to update docs and you will update later)

• doc-not-needed
  (Please explain why)

• doc
  (Your PR contains doc changes)

• doc-complete
  (Docs have been already added)

[TakaHiR07]

@HQebupt @Jason918 @AnonHxy Please take a look.

[HQebupt]

Good catch! Please follow the PR naming standard. https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.wu6ygjne8e35

[AnonHxy]

Nice catch.

The code below hide the exception, that's why the test can pass without throw exception. I think the code below wants to try to solve the same problem as #17251, but has some problem.

I think that we can also remove the code from Line4399-Line4402. Because #17251 fix it better. WDYT @TakaHiR07

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java

Lines 4398 to 4405 in dab0d1f

	}).thenAccept(__ -> result.complete(null)).exceptionally(ex -> {
	if (force && ex.getCause() instanceof PulsarAdminException.ConflictException) {
	result.complete(null);
	return null;
	}
	result.completeExceptionally(ex);
	return null;
	});

[TakaHiR07]

Nice catch.

The code below hide the exception, that's why the test can pass without throw exception. I think the code below wants to try to solve the same problem as #17251, but has some problem.

I think that we can also remove the code from Line4399-Line4402. Because #17251 fix it better. WDYT @TakaHiR07

pulsar/pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/PersistentTopicsBase.java

Lines 4398 to 4405 in dab0d1f

	}).thenAccept(__ -> result.complete(null)).exceptionally(ex -> {
	if (force && ex.getCause() instanceof PulsarAdminException.ConflictException) {
	result.complete(null);
	return null;
	}
	result.completeExceptionally(ex);
	return null;
	});

@AnonHxy I think it is good! We do not need this code after #17251.

I have force-push to contain this change.

[AnonHxy]

@Jason918 PTAL

[Jason918]

LGTM