-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][test] Fix ClientDeduplicationFailureTest.testClientDeduplicationWithBkFailure
#17387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mattisonchao Please provide a correct documentation label for your PR. |
|
|
||
| @Slf4j | ||
| @Test(groups = "quarantine") | ||
| @Test(groups = "broker") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this added in #16605? before taking tests out of quarantine, it should be ensured that the test is not flaky any more. The problem fixed in this PR isn't about flakiness. Have you verified that ClientDeduplicationFailureTest is no more flaky?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to verify? Do we have any rules for leaving the flaky test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can change the test group in another PR.
@lhotari If we can't reproduce the problem, it seems it's hard to judge whether the test is flaky or not, maybe the flaky problem was fixed in some PRs. I think we need to find a way to observe the failed frequency of the flaky tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can discuss it in another thread. I will roll back the test group.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @mattisonchao, in fact, if we can't reproduce the problem, it seems it's hard to judge whether the test is flaky or not, maybe run hundreds of times, and the problem presents a few times.
pulsar-broker/src/test/java/org/apache/pulsar/client/api/ClientDeduplicationFailureTest.java
Outdated
Show resolved
Hide resolved
…tDeduplicationFailureTest.java
Motivation
This problem may be caused by #16605.
Modifications
ClassCastExceptionVerifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below or label this PR directly.
Need to update docs?
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)