Skip to content

Conversation

@mattisonchao
Copy link
Member

Motivation

image

This problem may be caused by #16605.

Modifications

  • Fix ClassCastException

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

@mattisonchao Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.


@Slf4j
@Test(groups = "quarantine")
@Test(groups = "broker")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this added in #16605? before taking tests out of quarantine, it should be ensured that the test is not flaky any more. The problem fixed in this PR isn't about flakiness. Have you verified that ClientDeduplicationFailureTest is no more flaky?

Copy link
Member Author

@mattisonchao mattisonchao Sep 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How to verify? Do we have any rules for leaving the flaky test?

Copy link
Contributor

@gaoran10 gaoran10 Sep 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can change the test group in another PR.

@lhotari If we can't reproduce the problem, it seems it's hard to judge whether the test is flaky or not, maybe the flaky problem was fixed in some PRs. I think we need to find a way to observe the failed frequency of the flaky tests.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can discuss it in another thread. I will roll back the test group.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @mattisonchao, in fact, if we can't reproduce the problem, it seems it's hard to judge whether the test is flaky or not, maybe run hundreds of times, and the problem presents a few times.

@mattisonchao
Copy link
Member Author

mattisonchao commented Sep 2, 2022

Rollback the test group. Please review again @lhotari @gaoran10

@mattisonchao mattisonchao merged commit bab7faf into apache:master Sep 2, 2022
@mattisonchao mattisonchao deleted the fix_failed_test branch September 2, 2022 06:49
nodece pushed a commit to nodece/pulsar that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants