[improve][broker] Use safeRun to log thread exception in PersistentDispatcherMultipleConsumers#17484
Merged
Technoboy- merged 1 commit intoapache:masterfrom Sep 8, 2022
Merged
Conversation
Technoboy-
added
type/enhancement
nicoloboschi
approved these changes
Sep 6, 2022
Contributor
nicoloboschi
left a comment
nicoloboschi
left a comment
There was a problem hiding this comment.
Good catch! we should include it in 2.11
gaoran10
approved these changes
Sep 6, 2022
HQebupt
approved these changes
Sep 6, 2022
codelipenghui
approved these changes
Sep 7, 2022
AnonHxy
approved these changes
Sep 7, 2022
eolivelli
approved these changes
Sep 7, 2022
eolivelli
changed the title
safeRun to log thread exception.safeRun to log thread exception in PersistentDispatcherMultipleConsumers
Jason918
approved these changes
Sep 7, 2022
Technoboy-
force-pushed
the
use-saferun
branch
from
f20def2 to
9487204
Compare
Technoboy-
added a commit
that referenced
this pull request
Sep 8, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Sep 8, 2022
(cherry picked from commit 8c14868)
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When I troubleshoot the key_shared subscription issue, there are no error logs on the broker side. I find the error info from the broker dump file. It's a RuntimeException that causes the thread to crash, so no error logs.
So suggest using
safeRunon the dispatcher thread.Documentation
doc-not-needed(Please explain why)