[branch-2.10][fix][flaky-test] ManagedCursorMetricsTest.testManagedCursorMetrics

[poorbarcode]

Fixes

• Flaky-test: ManagedCursorMetricsTest.testManagedCursorMetrics #9919

Motivation & Modifications

PR #16878 cannot be cherry-picked to branch-2.10, there will be a conflict. so create this new PR.

---

(High light) The logic differs from #16878:

• after cursor init: metrics brk_ml_cursor_persistLedgerSucceed is 0 in branch-master. But in current PR, it is 1

"createNewMetadataLedger" triggers once BK writes

• in branch-2.10, "cursor.initialize" triggers the execution of "createNewMetadataLedger". see [Code in branch-2.10]
• in branch-master, "cursor.initialize" does not triggers the execution of "createNewMetadataLedger". see [Code in branch-master]

Code in branch-2.10 (High light line: L651)

pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java

Lines 643 to 663 in 8409652

	void initialize(PositionImpl position, Map<String, Long> properties, Map<String, String> cursorProperties,
	final VoidCallback callback) {
	recoveredCursor(position, properties, cursorProperties, null);
	if (log.isDebugEnabled()) {
	log.debug("[{}] Consumer {} cursor initialized with counters: consumed {} mdPos {} rdPos {}",
	ledger.getName(), name, messagesConsumedCounter, markDeletePosition, readPosition);
	}
	createNewMetadataLedger(new VoidCallback() {
	@Override
	public void operationComplete() {
	STATE_UPDATER.set(ManagedCursorImpl.this, State.Open);
	callback.operationComplete();
	}
	@Override
	public void operationFailed(ManagedLedgerException exception) {
	callback.operationFailed(exception);
	}
	});
	}

Code in branch-master (High light line: L653)

pulsar/managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java

Lines 646 to 665 in f453e0a

	void initialize(PositionImpl position, Map<String, Long> properties, Map<String, String> cursorProperties,
	final VoidCallback callback) {
	recoveredCursor(position, properties, cursorProperties, null);
	if (log.isDebugEnabled()) {
	log.debug("[{}] Consumer {} cursor initialized with counters: consumed {} mdPos {} rdPos {}",
	ledger.getName(), name, messagesConsumedCounter, markDeletePosition, readPosition);
	}
	persistPositionMetaStore(cursorLedger != null ? cursorLedger.getId() : -1L, position, properties,
	new MetaStoreCallback<>() {
	@Override
	public void operationComplete(Void result, Stat stat) {
	STATE_UPDATER.set(ManagedCursorImpl.this, State.NoLedger);
	callback.operationComplete();
	}
	@Override
	public void operationFailed(MetaStoreException e) {
	callback.operationFailed(e);
	}
	}, false);
	}

Documentation

• doc-required

• doc-not-needed

• doc

• doc-complete

[poorbarcode]

/pulsarbot rerun-failure-checks

[poorbarcode]

/pulsarbot rerun-failure-checks

[github-actions]

The pr had no activity for 30 days, mark with Stale label.

[tisonkun]

Thanks for your contribution!

Merging...