[improve][ci] add back cpp-test name #17742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
approved these changes
Sep 20, 2022
Member
@tisonkun please explain the reasoning in the PR description. |
lhotari
approved these changes
Sep 20, 2022
Member
Author
|
@lhotari updated. |
Member
Thanks! Much better now. (I don't like click baiting in PR descriptions. :)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #17571 (comment), we remove the canonical name of
cpp-testdue to a deadlock between changing the request statuses and the workflow. Now we add back the canonical name "CI - CPP, Python Tests" to eliminate the trick.Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: trivial to not have one.
cc @lhotari @nicoloboschi