-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][ci][branch-2.10] Fix owasp ci failure on branch-2.10 #17765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@lhotari @nicoloboschi @dlg99 PTAL |
|
why do we do this only on this branch ? |
@eolivelli The master branch won't have this issue as presto is upgraded in #16683. I am not sure when this owasp check starts failing. But I think we missed a step to trigger a full CI before cutting a release candidate. Currently owasp check will be skipped if there are no modifications on "pom" files. I will put some updates to the release process after this release. |
778c6c3 to
194e752
Compare
|
@nicoloboschi @lhotari |
|
Current OWASP Dependency Check fails because of "CVE-2022-25857" which is fixed in #17457. |
(cherry picked from commit aa68ef8)
Motivation
Currently owasp ci check fails on branch-2.10.
See https://github.com/Jason918/pulsar/actions/runs/3088190603/jobs/4994380011#step:8:53
Modifications
Exclude distribution and distribution/server from owasp check.
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-neededbug fix
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: Jason918#6
branch-2.10 in my fork contains this PR. See https://github.com/Jason918/pulsar/tree/branch-2.10