[fix][broker] Fix thread-safety issue with currentLedgerEntries and currentLedgerSize fields #17868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I noticed this while working on #17252 |
|
The pr had no activity for 30 days, mark with Stale label. |
…urrentLedgerSize fields - currentLedgerEntries and currentLedgerSize fields are currently mutated and read from multiple threads which is a problem. - one solution is to make the fields volatile
lhotari
force-pushed
the
lh-fix-ledger-counters-threadsafety
branch
from
1b413f1 to
fdff41a
Compare
michaeljmarshall
approved these changes
Dec 20, 2022
michaeljmarshall
added
type/cleanup
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17868 +/- ##
============================================
+ Coverage 45.92% 46.48% +0.55%
- Complexity 10104 10477 +373
============================================
Files 680 706 +26
Lines 66758 69004 +2246
Branches 7147 7392 +245
============================================
+ Hits 30660 32077 +1417
- Misses 32680 33323 +643
- Partials 3418 3604 +186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Modifications
Documentation
doc-required(Your PR needs to update docs and you will update later)
doc-not-needed(Please explain why)
doc(Your PR contains doc changes)
doc-complete(Docs have been already added)
Matching PR in forked repository
PR in forked repository: lhotari#93