[improve][test] Add test case for system topic schema not compatible bug.#17992
Merged
Technoboy- merged 1 commit intoapache:masterfrom Oct 17, 2022
Merged
Conversation
codelipenghui
approved these changes
Oct 12, 2022
Contributor
|
@dragonls I think it should also cherry-pick to branch-2.11 and branch-2.9 right? |
Contributor
Author
Codecov Report
@@ Coverage Diff @@
## master #17992 +/- ##
=============================================
+ Coverage 34.91% 49.37% +14.45%
- Complexity 5707 6927 +1220
=============================================
Files 607 393 -214
Lines 53396 43422 -9974
Branches 5712 4462 -1250
=============================================
+ Hits 18644 21438 +2794
+ Misses 32119 19598 -12521
+ Partials 2633 2386 -247
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Oct 13, 2022
Technoboy-
force-pushed
the
add-system-topic-schema-test
branch
from
5f55151 to
2a4fadb
Compare
Technoboy-
changed the title
Technoboy-
pushed a commit
that referenced
this pull request
Oct 17, 2022
…bug. (#17992) Co-authored-by: druidliu <druidliu@tencent.com>
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 6, 2022
…bug. (apache#17992) Co-authored-by: druidliu <druidliu@tencent.com> (cherry picked from commit 96cc240) (cherry picked from commit a585dd9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #17979
Related to #17986
Motivation
Add test case to cover system topic schema compatibility.
Modifications
Add test case (
org.apache.pulsar.broker.systopic.NamespaceEventsSystemTopicServiceTest#testSystemTopicSchemaCompatibility) to cover system topic schema compatibility.The
schemaCompatibilityStrategyof system topic should always be the same as the confsystemTopicSchemaCompatibilityStrategy, which is defaultSchemaCompatibilityStrategy.ALWAYS_COMPATIBLE.Verifying this change
This change added tests and can be verified as follows:
org.apache.pulsar.broker.systopic.NamespaceEventsSystemTopicServiceTest#testSystemTopicSchemaCompatibilityDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: dragonls#2