[fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker #18000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattisonchao
approved these changes
Oct 11, 2022
Member
mattisonchao
left a comment
mattisonchao
left a comment
There was a problem hiding this comment.
Can we add a test for it?
codelipenghui
approved these changes
Oct 12, 2022
codelipenghui
added
type/bug
Codecov Report
@@ Coverage Diff @@
## master #18000 +/- ##
=========================================
Coverage ? 47.20%
Complexity ? 6376
=========================================
Files ? 367
Lines ? 41173
Branches ? 4216
=========================================
Hits ? 19437
Misses ? 19524
Partials ? 2212
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Member
Author
|
/pulsarbot run-failure-checks |
coderzc
force-pushed
the
fix_InMemoryDelayedDeliveryTracker_close
branch
from
8d09402 to
bbba3bf
Compare
Member
Author
I add |
Technoboy-
approved these changes
Oct 13, 2022
Member
Author
|
/pulsarbot run-failure-checks |
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 6, 2022
…eliveryTracker (apache#18000) (cherry picked from commit 44ae348) (cherry picked from commit a9c67fa)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the InMemoryDelayedDeliveryTracker, the
priorityQueueshould be closed after thetimeouttask is canceled, otherwise, we may operate thepriorityQueuethat has been closed.Modifications
Close the
priorityQueueafter thetimeouttask is canceled and set timeout=null.Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: coderzc#11