Skip to content

Conversation

@nicoloboschi
Copy link
Contributor

Motivation

After #17887 there are a lot of failures in the CI

java.lang.NullPointerException: Cannot invoke "org.apache.pulsar.broker.PulsarService.getConfiguration()" because "this.pulsar" is null
	at org.apache.pulsar.client.api.SimpleProducerConsumerTest.rest(SimpleProducerConsumerTest.java:138)
java.lang.NullPointerException: Cannot invoke "org.apache.pulsar.client.api.PulsarClient.newConsumer()" because "this.pulsarClient" is null
	at org.apache.pulsar.client.api.SimpleProducerConsumerTest.testConcurrentConsumerReceiveWhileReconnect(SimpleProducerConsumerTest.java:880)

The reason is that the after method is always executed meanwhile the setup method is not+

Modifications

  • Add back alwaysRun=true in the setup method

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2022

Codecov Report

❗ No coverage uploaded for pull request base (master@92b4708). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #18068   +/-   ##
=========================================
  Coverage          ?   45.81%           
  Complexity        ?    17567           
=========================================
  Files             ?     1574           
  Lines             ?   128320           
  Branches          ?    14116           
=========================================
  Hits              ?    58794           
  Misses            ?    63452           
  Partials          ?     6074           
Flag Coverage Δ
unittests 45.81% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@nicoloboschi nicoloboschi merged commit 302854e into apache:master Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/test doc-not-needed Your PR changes do not impact docs ready-to-test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants