Skip to content

Conversation

@coderzc
Copy link
Member

@coderzc coderzc commented Oct 20, 2022

Motivation

Prometheus load metrics error.
image

curl -s 'http://localhost:8080/metrics/'

image

This bug introduce from #15558

Modifications

Remove the space behind the metric type.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 20, 2022
@coderzc coderzc changed the title [fix][broker] Fix invalid metric type "gauge " [fix][broker][functions-worker] Fix invalid metric type "gauge " Oct 20, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Oct 20, 2022
@Technoboy- Technoboy- added type/bug The PR fixed a bug or issue reported a bug area/broker ready-to-test labels Oct 20, 2022
@Technoboy- Technoboy- closed this Oct 20, 2022
@Technoboy- Technoboy- reopened this Oct 20, 2022
@Technoboy- Technoboy- changed the title [fix][broker][functions-worker] Fix invalid metric type "gauge " [fix][function] Fix invalid metric type "gauge " Oct 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2022

Codecov Report

Merging #18129 (55dbe86) into master (6c65ca0) will increase coverage by 16.85%.
The diff coverage is 68.96%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #18129       +/-   ##
=============================================
+ Coverage     34.91%   51.77%   +16.85%     
- Complexity     5707     7251     +1544     
=============================================
  Files           607      393      -214     
  Lines         53396    43484     -9912     
  Branches       5712     4471     -1241     
=============================================
+ Hits          18644    22514     +3870     
+ Misses        32119    18458    -13661     
+ Partials       2633     2512      -121     
Flag Coverage Δ
unittests 51.77% <68.96%> (+16.85%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...pache/pulsar/broker/admin/impl/NamespacesBase.java 63.98% <ø> (+49.45%) ⬆️
.../pulsar/broker/service/AbstractBaseDispatcher.java 50.30% <ø> (+4.44%) ⬆️
...che/pulsar/broker/service/BacklogQuotaManager.java 12.39% <0.00%> (+2.91%) ⬆️
.../service/SystemTopicBasedTopicPoliciesService.java 62.97% <0.00%> (+11.38%) ⬆️
.../pulsar/broker/stats/BrokerOperabilityMetrics.java 100.00% <ø> (+7.35%) ⬆️
...g/apache/pulsar/compaction/CompactedTopicImpl.java 69.28% <0.00%> (+58.57%) ⬆️
.../org/apache/pulsar/broker/admin/v2/Namespaces.java 57.36% <50.00%> (+49.33%) ⬆️
...ache/pulsar/broker/service/EntryFilterSupport.java 32.43% <50.00%> (+7.43%) ⬆️
...apache/pulsar/proxy/server/DirectProxyHandler.java 63.63% <50.00%> (ø)
...broker/delayed/InMemoryDelayedDeliveryTracker.java 65.00% <75.00%> (+65.00%) ⬆️
... and 406 more

@coderzc
Copy link
Member Author

coderzc commented Oct 20, 2022

@Technoboy- Also need to cherry-pick 2.9.x.

@Technoboy- Technoboy- merged commit 39270f0 into apache:master Oct 24, 2022
congbobo184 pushed a commit that referenced this pull request Nov 9, 2022
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 9, 2022
congbobo184 pushed a commit that referenced this pull request Nov 26, 2022
liangyepianzhou pushed a commit that referenced this pull request Dec 14, 2022
@asafm
Copy link
Contributor

asafm commented Dec 19, 2022

Oh, man. Who would have thought this would be an issue? We probably need an e2e test using real Prometheus docker on this. Thanks for the fix @coderzc .

@marksilcox CC

nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 10, 2023
(cherry picked from commit 39270f0)
(cherry picked from commit c5d4355)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 11, 2023
(cherry picked from commit 39270f0)
(cherry picked from commit c5d4355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants