-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][function] Fix invalid metric type "gauge " #18129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
approved these changes
Oct 20, 2022
Codecov Report
@@ Coverage Diff @@
## master #18129 +/- ##
=============================================
+ Coverage 34.91% 51.77% +16.85%
- Complexity 5707 7251 +1544
=============================================
Files 607 393 -214
Lines 53396 43484 -9912
Branches 5712 4471 -1241
=============================================
+ Hits 18644 22514 +3870
+ Misses 32119 18458 -13661
+ Partials 2633 2512 -121
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
|
@Technoboy- Also need to cherry-pick 2.9.x. |
tjiuming
approved these changes
Oct 23, 2022
congbobo184
pushed a commit
that referenced
this pull request
Nov 9, 2022
congbobo184
pushed a commit
that referenced
this pull request
Nov 26, 2022
liangyepianzhou
pushed a commit
that referenced
this pull request
Dec 14, 2022
Contributor
|
Oh, man. Who would have thought this would be an issue? We probably need an e2e test using real Prometheus docker on this. Thanks for the fix @coderzc . @marksilcox CC |
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
cherry-picked/branch-2.11
doc-not-needed
Your PR changes do not impact docs
ready-to-test
release/2.9.4
release/2.10.3
release/2.11.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Prometheus load metrics error.

This bug introduce from #15558
Modifications
Remove the space behind the metric type.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: