Skip to content

[fix][cli] Fix CLI client produce don't able to use multiple -m send multiple messages #18238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
codelipenghui merged 1 commit into from
Oct 28, 2022
Merged

[fix][cli] Fix CLI client produce don't able to use multiple -m send multiple messages #18238

codelipenghui merged 1 commit into from
Oct 28, 2022

Conversation

@coderzc
Copy link
Member

@coderzc coderzc commented Oct 28, 2022

Fixes #18233

Motivation

Fix CLI client produce don't able to use multiple -m send multiple messages.

Modifications

Traverse messages and split them.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • testSendMultipleMessage.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Oct 28, 2022
@Technoboy- Technoboy- added this to the 2.12.0 milestone Oct 28, 2022
@Technoboy- Technoboy- closed this Oct 28, 2022
@Technoboy- Technoboy- reopened this Oct 28, 2022
@tisonkun
Copy link
Member

tisonkun commented Oct 28, 2022

Cool! Thank you.

@codelipenghui codelipenghui added type/bug The PR fixed a bug or issue reported a bug release/2.9.4 release/2.11.1 release/2.10.3 labels Oct 28, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022 •
edited
Loading

Codecov Report

Merging #18238 (eb73130) into master (6c65ca0) will decrease coverage by 2.93%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #18238      +/-   ##
============================================
- Coverage     34.91%   31.98%   -2.94%     
+ Complexity     5707     4216    -1491     
============================================
  Files           607      398     -209     
  Lines         53396    43561    -9835     
  Branches       5712     4478    -1234     
============================================
- Hits          18644    13931    -4713     
+ Misses        32119    27570    -4549     
+ Partials       2633     2060     -573
Flag Coverage Δ
unittests 31.98% <ø> (-2.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/apache/pulsar/PulsarBrokerStarter.java 0.00% <ø> (ø)
.../org/apache/pulsar/PulsarClusterMetadataSetup.java 0.00% <ø> (ø)
...g/apache/pulsar/PulsarClusterMetadataTeardown.java 0.00% <ø> (ø)
.../org/apache/pulsar/client/impl/RawMessageImpl.java 0.00% <0.00%> (-93.11%) ⬇️
...rvice/schema/KeyValueSchemaCompatibilityCheck.java 8.10% <0.00%> (-59.46%) ⬇️
...tent/NonPersistentDispatcherMultipleConsumers.java 0.00% <0.00%> (-48.15%) ⬇️
...apache/pulsar/broker/service/TopicListService.java 10.65% <0.00%> (-44.27%) ⬇️
...java/org/apache/pulsar/proxy/stats/TopicStats.java 58.82% <0.00%> (-41.18%) ⬇️
.../service/schema/validator/SchemaDataValidator.java 36.84% <0.00%> (-26.32%) ⬇️
...apache/pulsar/broker/admin/v2/SchemasResource.java 18.07% <0.00%> (-19.28%) ⬇️
... and 333 more

@codelipenghui codelipenghui merged commit 67a3de7 into apache:master Oct 28, 2022
Technoboy- pushed a commit that referenced this pull request Nov 3, 2022
@coderzc @Technoboy-
[fix][cli] Fix CLI client produce don't able to use multiple -m send …
ffd67a2 
…multiple messages (#18238)
@Technoboy- Technoboy- modified the milestones: 2.12.0, 2.11.0 Nov 3, 2022
@congbobo184 congbobo184 added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Nov 8, 2022
congbobo184 pushed a commit that referenced this pull request Nov 26, 2022
@coderzc
[fix][cli] Fix CLI client produce don't able to use multiple -m send …
f934f37 
…multiple messages (#18238)

(cherry picked from commit 67a3de7)
liangyepianzhou pushed a commit that referenced this pull request Dec 14, 2022
@coderzc @liangyepianzhou
[fix][cli] Fix CLI client produce don't able to use multiple -m send …
dfce020 
…multiple messages (#18238)

(cherry picked from commit 67a3de7)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 10, 2023
@coderzc @nicoloboschi
[fix][cli] Fix CLI client produce don't able to use multiple -m send …
3af933d 
…multiple messages (apache#18238)

(cherry picked from commit 67a3de7)
(cherry picked from commit dfce020)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jan 11, 2023
@coderzc @nicoloboschi
[fix][cli] Fix CLI client produce don't able to use multiple -m send …
6c632e4 
…multiple messages (apache#18238)

(cherry picked from commit 67a3de7)
(cherry picked from commit dfce020)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@nodece nodece nodece approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees

@coderzc coderzc

Labels

area/cli cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 cherry-picked/branch-2.11 doc-not-needed Your PR changes do not impact docs ready-to-test release/2.9.4 release/2.10.3 type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Milestone

2.11.0

Development

Successfully merging this pull request may close these issues.

[Bug] Pulsar Shell client produce multiple -m only the first one fired

8 participants

@coderzc @tisonkun @codecov-commenter @Technoboy- @codelipenghui @nodece @congbobo184 @liangyepianzhou