Added option for custom loggers in C++ and C APIs #1827
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/enhancement
Contributor
Author
|
retest this please |
1 similar comment
Contributor
Author
|
retest this please |
sijie
approved these changes
May 22, 2018
Member
sijie
left a comment
sijie
left a comment
There was a problem hiding this comment.
#shipit
just one note: we need to list in the release notes that people need to specify -DUSE_LOG4XX when using the new cpp client.
This was referenced Jan 3, 2020
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-cpp
that referenced
this pull request
Jun 13, 2023
### Motivation See apache/pulsar#1827, which also marked the log4cxx configurations as deprecated. ### Modifications Remove all log4cxx related stuff. log4cxx users can implement their own `LoggerFactory` like the built-in implementation before this PR.
BewareMyPower
added a commit
to BewareMyPower/pulsar-client-cpp
that referenced
this pull request
Jun 13, 2023
### Motivation See apache/pulsar#1827, which also marked the log4cxx configurations as deprecated. ### Modifications Remove all log4cxx related stuff. log4cxx users can implement their own `LoggerFactory` like the built-in implementation before this PR.
4 tasks
shibd
pushed a commit
to apache/pulsar-client-cpp
that referenced
this pull request
Jun 13, 2023
* Remove log4cxx dependency and its specified configuration ### Motivation See apache/pulsar#1827, which also marked the log4cxx configurations as deprecated. ### Modifications Remove all log4cxx related stuff. log4cxx users can implement their own `LoggerFactory` like the built-in implementation before this PR. * Fix Windows compilation error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In many cases, the supplied Log4CXX logger for C++ is not practical or convenient for users.
For examples, when using C++ client library wrapped in Python / Go the log messages from pulsar client library do not interact well with the the logs of the rest of the application.
The same happens when a C++ application is already using a different logging framework than Log4cxx.
Modifications
LoggerFactoryandLoggerimplementationcmake -DUSE_LOG4CXX