[fix][client] Support LocalDateTime Conversion #18334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
Nov 4, 2022
nodece
added
area/client
release/2.10.3
ready-to-test
type/bug
coderzc
force-pushed
the
fix_LocalDateTime
branch
from
1a5cd93 to
5f845ec
Compare
labuladong
approved these changes
Nov 4, 2022
lhotari
reviewed
Nov 4, 2022
| reflectData.addLogicalTypeConversion(new TimeConversions.LocalTimestampMicrosConversion()); | ||
| reflectData.addLogicalTypeConversion(new TimeConversions.LocalTimestampMillisConversion()); |
Member
There was a problem hiding this comment.
why weren't these put under the if statement if (jsr310ConversionEnabled) { ?
Member
Author
There was a problem hiding this comment.
Because there is no Joda time conversion of local-timestamp-millis and local-timestamp-micros, I think don't need to judge jsr310ConversionEnabled.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18334 +/- ##
============================================
+ Coverage 39.98% 45.47% +5.49%
- Complexity 8590 10700 +2110
============================================
Files 685 752 +67
Lines 67335 72525 +5190
Branches 7216 7792 +576
============================================
+ Hits 26924 32983 +6059
+ Misses 37392 35854 -1538
- Partials 3019 3688 +669
Flags with carried forward coverage won't be shown. Click here to find out more.
|
coderzc
force-pushed
the
fix_LocalDateTime
branch
from
5f845ec to
7882a4d
Compare
coderzc
commented
Nov 5, 2022
| } catch (ClassNotFoundException e) { | ||
| // Skip if have not provide joda-time dependency. | ||
| } | ||
| reflectData.addLogicalTypeConversion(new TimeConversions.TimestampMicrosConversion()); |
Member
Author
There was a problem hiding this comment.
Should be able to move to line 134, otherwise we will not be able to parse timestamp-micros type when jsr310ConversionEnabled == true.
Member
Author
|
/pulsarbot run-failure-checks |
Member
Author
|
@lhotari please take a look again. |
lhotari
approved these changes
Nov 9, 2022
lhotari
approved these changes
Nov 9, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Nov 9, 2022
* Support LocalDateTime Conversion * move `TimestampMicrosConversion` to correct line (cherry picked from commit b31c5a6)
congbobo184
pushed a commit
that referenced
this pull request
Nov 10, 2022
* Support LocalDateTime Conversion * move `TimestampMicrosConversion` to correct line (cherry picked from commit b31c5a6)
congbobo184
pushed a commit
that referenced
this pull request
Nov 26, 2022
* Support LocalDateTime Conversion * move `TimestampMicrosConversion` to correct line (cherry picked from commit b31c5a6)
liangyepianzhou
pushed a commit
that referenced
this pull request
Dec 14, 2022
* Support LocalDateTime Conversion * move `TimestampMicrosConversion` to correct line (cherry picked from commit b31c5a6)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
* Support LocalDateTime Conversion * move `TimestampMicrosConversion` to correct line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18329
Motivation
Due to missing LocalDateTime ConVersion, the decode
java.time.LocalDateTimefailure.Modifications
Add
LocalTimestampMicrosConversionandLocalTimestampMillisConversionfor AvroSchema.Verifying this change
This change added tests and can be verified as follows:
testLocalDateTime
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: