[improve][test] Add subscribing regex topic test for delete_when_subscriptions_caught_up.
#18368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Technoboy-
changed the title
delete_when_subscriptions_caught_up.delete_when_subscriptions_caught_up.
Codecov Report
@@ Coverage Diff @@
## master #18368 +/- ##
============================================
- Coverage 47.23% 45.04% -2.19%
- Complexity 10430 10639 +209
============================================
Files 692 757 +65
Lines 67766 72782 +5016
Branches 7260 7826 +566
============================================
+ Hits 32009 32788 +779
- Misses 32192 36335 +4143
- Partials 3565 3659 +94
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mattisonchao
approved these changes
Nov 7, 2022
pulsar-broker/src/test/java/org/apache/pulsar/broker/service/InactiveTopicDeleteTest.java
Show resolved
Hide resolved
| Assert.assertFalse(admin.topics().getList("prop/ns-abc").contains(topic2)); | ||
| }); | ||
| consumer.close(); | ||
| consumer2.close(); |
Contributor
There was a problem hiding this comment.
We should check that consumer2 has no internal consumers eventually or we can say all the internal consumers are closed due to the topic being deleted.
Contributor
Author
There was a problem hiding this comment.
Ah, line 358 has checked all the consumers.
congbobo184
approved these changes
Nov 15, 2022
gaoran10
reviewed
Nov 15, 2022
Contributor
gaoran10
left a comment
gaoran10
left a comment
There was a problem hiding this comment.
Sorry, I have a little confused, why the topic can be deleted? It seems the topic has connected consumers.
Contributor
Author
Ah, some motivation and modification can be found here #18283 |
poorbarcode
approved these changes
Nov 15, 2022
Technoboy-
force-pushed
the
improve-topic-policies
branch
from
9ea0a2b to
2b81800
Compare
gaoran10
approved these changes
Nov 15, 2022
codelipenghui
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add subscribing regex topic test for #18283.
Documentation
docdoc-requireddoc-not-neededdoc-complete