[improve][client] Change the get lastMessageId to debug level#18421
Merged
codelipenghui merged 1 commit intoapache:masterfrom Nov 14, 2022
Merged
[improve][client] Change the get lastMessageId to debug level#18421codelipenghui merged 1 commit intoapache:masterfrom
codelipenghui merged 1 commit intoapache:masterfrom
Conversation
|
@zymap Please add the following content to your PR description and select a checkbox: |
zymap
added
type/enhancement
--- ### Motivation When using RawReader to read the topic, the getLastMessageId continue to print to the logs, change it to the debug leve to avoid print it to much.
zymap
force-pushed
the
log-info-to-debug
branch
from
368b109 to
c3a57c4
Compare
hangc0276
approved these changes
Nov 11, 2022
lifepuzzlefun
approved these changes
Nov 11, 2022
merlimat
approved these changes
Nov 11, 2022
Contributor
|
Good catch ! |
RobertIndie
approved these changes
Nov 11, 2022
codelipenghui
approved these changes
Nov 11, 2022
Contributor
|
/pulsarbot run-failure-checks |
Codecov Report
@@ Coverage Diff @@
## master #18421 +/- ##
=============================================
- Coverage 46.98% 30.09% -16.90%
+ Complexity 10343 5705 -4638
=============================================
Files 692 613 -79
Lines 67766 58395 -9371
Branches 7259 6088 -1171
=============================================
- Hits 31842 17575 -14267
- Misses 32344 38354 +6010
+ Partials 3580 2466 -1114
Flags with carried forward coverage won't be shown. Click here to find out more.
|
liangyepianzhou
pushed a commit
that referenced
this pull request
Feb 6, 2023
(cherry picked from commit ac9742a)
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
coderzc
pushed a commit
that referenced
this pull request
Feb 28, 2023
(cherry picked from commit ac9742a)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When using RawReader to read the topic, the getLastMessageId continues to print to the logs, change it to the debug level to avoid printing it too much.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: zymap#42