Skip to content

[fix][schema] Fix cherry-pick issue from #18283 #18555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mattisonchao merged 3 commits into from
Nov 21, 2022
Merged

[fix][schema] Fix cherry-pick issue from #18283 #18555

mattisonchao merged 3 commits into from
Nov 21, 2022

Conversation

@mattisonchao
Copy link
Member

@mattisonchao mattisonchao commented Nov 21, 2022 •
edited
Loading

Motivation

#14608 Introduce a new break change about the delete schema logic of topic deletion starting from 2.11(milestone), #18283 cherry-picked this logic to branch-2.10 and branch-2.9. I'm wondering if it's better to roll back this kind of logic.

Modifications

  • Roll back delete schema logic of topic deletion.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao added release/blocker Indicate the PR or issue that should block the release until it gets resolved release/2.9.4 release/2.10.3 labels Nov 21, 2022
@mattisonchao mattisonchao self-assigned this Nov 21, 2022
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Nov 21, 2022
@mattisonchao mattisonchao changed the title [fix][schema] Fix break change about topic deletion. [fix][schema] Fix break change about delete schema of topic deletion. Nov 21, 2022
@codelipenghui
Copy link
Contributor

codelipenghui commented Nov 21, 2022

It should be a cherry-pick issue from #18283
It's better to change the PR title to "Fix cherry-pick issue from #18283"

@mattisonchao mattisonchao changed the title [fix][schema] Fix break change about delete schema of topic deletion. [fix][schema] Fix cherry-pick issue from #18283 Nov 21, 2022
yuruguo
yuruguo approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@yuruguo yuruguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattisonchao mattisonchao merged commit 9343a35 into branch-2.10 Nov 21, 2022
@mattisonchao mattisonchao deleted the fix_schema_regression branch November 21, 2022 07:31
mattisonchao added a commit that referenced this pull request Nov 21, 2022
@mattisonchao
[fix][schema] Fix cherry-pick issue from #18283 (#18555)
0896eda
@mattisonchao mattisonchao added cherry-picked/branch-2.9 Archived: 2.9 is end of life and removed release/blocker Indicate the PR or issue that should block the release until it gets resolved labels Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Technoboy- Technoboy- Technoboy- approved these changes

@codelipenghui codelipenghui codelipenghui approved these changes

@yuruguo yuruguo yuruguo approved these changes

@Jason918 Jason918 Awaiting requested review from Jason918

@congbobo184 congbobo184 Awaiting requested review from congbobo184

+1 more reviewer

@yaalsn yaalsn yaalsn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mattisonchao mattisonchao

Labels

cherry-picked/branch-2.9 Archived: 2.9 is end of life cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs release/2.9.4 release/2.10.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mattisonchao @codelipenghui @Technoboy- @yaalsn @yuruguo