Skip to content

[branch-2.10] Fix no durable cursor leak problem #18708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gaozhangmin merged 1 commit into from
Dec 2, 2022
Merged

[branch-2.10] Fix no durable cursor leak problem #18708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -974,6 +974,7 @@ public synchronized void asyncDeleteCursor(final String consumerName, final Dele
return;
} else if (!cursor.isDurable()) {
cursors.removeCursor(consumerName);
cursor.setInactive();
callback.deleteCursorComplete(ctx);
return;
}
Expand All @@ -984,6 +985,7 @@ public synchronized void asyncDeleteCursor(final String consumerName, final Dele
@Override
public void operationComplete(Void result, Stat stat) {
cursor.asyncDeleteCursorLedger();
cursor.setInactive();
cursors.removeCursor(consumerName);

// Redo invalidation of entries in cache
Expand Down