[improve][txn] fix error in recoverTracker.handleCommittingAndAbortingTransaction() #18924
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested changes
Dec 14, 2022
| @@ -129,7 +130,6 @@ public void replayComplete() { | |||
| } else { | |||
Contributor
There was a problem hiding this comment.
better to move this line, because
https://github.com/apache/pulsar/pull/18924/files#diff-70bdccda00334bdcc596cb6fea9f166021fc858af8c0432a3ee86a6911150d07R123
in some case the tc will not recover success
Contributor
Author
There was a problem hiding this comment.
@congbobo184 I have moved future complete after changeToReadyState().
congbobo184
added
doc-not-needed
congbobo184
changed the title
TakaHiR07
force-pushed
the
fix_tc_recover_error
branch
from
2e29625 to
6346f64
Compare
congbobo184
approved these changes
Dec 14, 2022
Codecov Report
@@ Coverage Diff @@
## master #18924 +/- ##
=============================================
- Coverage 46.17% 33.77% -12.40%
+ Complexity 10359 6408 -3951
=============================================
Files 703 623 -80
Lines 68845 59104 -9741
Branches 7382 6146 -1236
=============================================
- Hits 31788 19963 -11825
- Misses 33448 36470 +3022
+ Partials 3609 2671 -938
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lifepuzzlefun
pushed a commit
to lifepuzzlefun/pulsar
that referenced
this pull request
Jan 10, 2023
…gTransaction() (apache#18924) Fixes apache#18923 ### Motivation As described in apache#18923, recoverTracker.handleCommittingAndAbortingTransaction() fail when TC recover. ### Modifications when transactionLog.replayAsync() finish, complete TC future.
Merged
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18923
Motivation
As described in #18923, recoverTracker.handleCommittingAndAbortingTransaction() fail when TC recover.
Modifications
when transactionLog.replayAsync() finish, complete TC future.
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: