-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][io] Only bundle kafka schema registry client #18931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][io] Only bundle kafka schema registry client #18931
Conversation
(cherry picked from commit 83f7503)
Codecov Report
@@ Coverage Diff @@
## master #18931 +/- ##
============================================
+ Coverage 46.17% 46.69% +0.51%
- Complexity 10359 10487 +128
============================================
Files 703 703
Lines 68845 68858 +13
Branches 7382 7383 +1
============================================
+ Hits 31788 32150 +362
+ Misses 33448 33089 -359
- Partials 3609 3619 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@nicoloboschi @eolivelli Is there a specific reason to stick to the old 5.3.0 schema registry client? 5.3.0 was released in July 2019. That is ancient. |
eolivelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
(cherry picked from commit a951549)
(cherry picked from commit a951549)
(cherry picked from commit a951549)
(cherry picked from commit a951549)
@nicoloboschi @eolivelli I've addressed the upgrade in #19010 |
Fixes #18920
Motivation
Only kafka-schema-registry-client has ASL license and the connector actually needs only it (and serializers, ASL too)
Modifications
kafka-schema-registry-clientinstead ofkafka-schema-registryDocumentation
docdoc-requireddoc-not-neededdoc-complete