[branch-2.10] Group prometheus metrics #18941
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metheusMetricsTest.java Co-authored-by: Dave Maughan <davidamaughan@gmail.com>
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
asafm
approved these changes
Dec 19, 2022
Contributor
asafm
left a comment
asafm
left a comment
There was a problem hiding this comment.
Very hard to do a meticulous review for this PR. I quickly reviewed it and mainly relied on the PR we did on the original one. Also validated the buffer release bug is not here.
codelipenghui
approved these changes
Dec 20, 2022
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 10, 2023
(cherry picked from commit 64f8708)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Jan 11, 2023
(cherry picked from commit 64f8708)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Cherry picked from #15558 with reference to fixes in #17852
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: https://github.com/marksilcox/pulsar/pull/7