[improve][io] Elasticsearch sink: Support loading config from secrets #18986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpreu
force-pushed
the
io-elasticsearch-config-secrets
branch
from
77cdee5 to
984801b
Compare
alpreu
force-pushed
the
io-elasticsearch-config-secrets
branch
from
984801b to
cad39c3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #18986 +/- ##
============================================
+ Coverage 46.35% 46.91% +0.55%
- Complexity 8939 10563 +1624
============================================
Files 597 706 +109
Lines 56858 69005 +12147
Branches 5905 7391 +1486
============================================
+ Hits 26357 32372 +6015
- Misses 27616 33032 +5416
- Partials 2885 3601 +716
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
Can we merge this? |
Contributor
|
/pulsarbot rerun-failure-checks |
Contributor
Author
|
@nicoloboschi The failing OWASP dependency check is independent of this PR, we cannot get it to turn green, it has to be fixed by itself. Can we go ahead with merging this change? |
alpreu
pushed a commit
to alpreu/pulsar
that referenced
this pull request
Jan 12, 2023
This was referenced Jan 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Elasticsearch sink does currently not support loading config properties such as credentials from secrets.
Modifications
Use
IOConfigUtils.loadWithSecretsto enable loading sensitive sink configurations from secrets too.Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: alpreu#3