[fix] [doc] Fix outdated java-doc of rate limiter #19014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc
poorbarcode
changed the title
poorbarcode
force-pushed
the
doc/fix_outdated_of_rate_limiter
branch
from
d5a1f5e to
54d18b5
Compare
congbobo184
reviewed
Dec 23, 2022
| public boolean tryDispatchPermit(long msgPermits, long bytePermits) { | ||
| boolean acquiredMsgPermit = msgPermits <= 0 || dispatchRateLimiterOnMessage == null | ||
| // acquiring permits must be < configured msg-rate; | ||
| // In dispatch mode, acquiring permits can be larger than configured msg-rate. |
Contributor
There was a problem hiding this comment.
dispatch mode represents what? it is singleDispatcher and multiDispatcher, right?
Contributor
Author
There was a problem hiding this comment.
dispatch mode represents what? it is singleDispatcher and multiDispatcher, right?
Yes, I have removed these two java-doc because it is outedated.
|
The pr had no activity for 30 days, mark with Stale label. |
congbobo184
approved these changes
Mar 22, 2023
Codecov Report
@@ Coverage Diff @@
## master #19014 +/- ##
=============================================
+ Coverage 49.85% 71.33% +21.48%
- Complexity 8658 31993 +23335
=============================================
Files 500 1942 +1442
Lines 54930 142522 +87592
Branches 5867 15624 +9757
=============================================
+ Hits 27386 101673 +74287
- Misses 24464 32764 +8300
- Partials 3080 8085 +5005
Flags with carried forward coverage won't be shown. Click here to find out more.
|
RobertIndie
approved these changes
Apr 11, 2023
Demogorgon314
pushed a commit
to Demogorgon314/pulsar
that referenced
this pull request
Apr 11, 2023
### Motivation After PR apache#8611, the acquiring permits can be larger than configured msg-rate if used by subscribing. But doc was not updated in time. ### Modifications fix the outdated doc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After PR #8611, the acquiring permits can be larger than configured msg-rate if used by subscribing. But doc was not updated in time.
Modifications
fix the outdated doc
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: