-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][broker] Fix configuration exposeSubscriptionBacklogSizeInPrometheus not working #19049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[fix][broker] Fix configuration exposeSubscriptionBacklogSizeInPrometheus not working #19049
Conversation
|
/pulsarbot rerun-failure-checks |
0441fe8 to
09e5f39
Compare
|
/pulsarbot rerun-failure-checks |
|
PTAL @codelipenghui |
gaoran10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
...ker/src/main/java/org/apache/pulsar/broker/stats/prometheus/AggregatedSubscriptionStats.java
Outdated
Show resolved
Hide resolved
09e5f39 to
4dfb6d4
Compare
|
@Shawyeok A PIP is required If the change will introduce a new indicator to the metrics endpoint. Please see https://github.com/apache/pulsar/blob/master/wiki/proposals/PIP.md and the discussion under the mailing list https://lists.apache.org/thread/bmwtk6zcyt4ft4t95jmz1bnsxbysjw8m I support the motivation. |
codelipenghui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PIP is required.
Ok, I'll draft a PIP in the weekend. |
|
The pr had no activity for 30 days, mark with Stale label. |
Motivation
Broker configuration
exposeSubscriptionBacklogSizeInPrometheuswas introduced in #9302, but it is true, broker just calculate the size of backlog and didn't expose it.Modifications
exposeSubscriptionBacklogSizeInPrometheus=true, expose the metric aspulsar_subscription_back_log_sizeVerifying this change
(Please pick either of the following options)
This change added tests and can be verified as follows:
exposeSubscriptionBacklogSizeInPrometheus=false, it shouldn't expose the metricexposeSubscriptionBacklogSizeInPrometheus=true, it should expose the metricDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: Shawyeok#6