[cleanup][broker] Remove AuthorizationProvider methods deprecated in 2.7 and 2.9 #19182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeljmarshall
added
type/cleanup
michaeljmarshall
changed the title
Codecov Report
@@ Coverage Diff @@
## master #19182 +/- ##
============================================
+ Coverage 47.45% 47.48% +0.02%
- Complexity 10760 10788 +28
============================================
Files 713 713
Lines 69672 69722 +50
Branches 7482 7492 +10
============================================
+ Hits 33063 33105 +42
- Misses 32895 32938 +43
+ Partials 3714 3679 -35
Flags with carried forward coverage won't be shown. Click here to find out more.
|
lhotari
approved these changes
Jan 11, 2023
mattisonchao
approved these changes
Jan 11, 2023
Member
mattisonchao
left a comment
mattisonchao
left a comment
There was a problem hiding this comment.
I think we need to notify in the release notion.
By the way, have you checked the corresponding test?
Member
|
Oh, I saw the label. Please ignore my comment first sentence. |
nodece
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have many methods in the
AuthorizationProviderinterface that have been annotated with@Deprecatedfor since the 2.7.0 release and the 2.9.0 release. The PR that deprecated most of these methods was merged August 2020: #7788. The other PR was #12064. These methods are not used by the Pulsar code base, but may technically be used by third party extensions, which is why it is important to be careful when removing them. That being said, enough time has passed. Removing these methods should make theAuthorizationProvidereasier to read and easier to use.Modifications
allowTenantOperationAsync,allowTenantOperation,allowNamespaceOperationAsync,allowNamespaceOperation,allowNamespacePolicyOperationAsync,allowNamespacePolicyOperation,allowTopicOperationAsync,allowTopicOperation(all deprecated by allowTopicOperationAsync should check the original role is super user (#1355) #7788)initializeand remove backwards compatibility references (deprecated by [PIP-45] Remove ConfigurationCacheService from AuthorizationProvider #12064)Verifying this change
I reviewed the git history and made sure the project compiles.
Does this pull request potentially affect one of the following parts:
This is technically a breaking change. I will send an email to the mailing list.
Documentation
doc-not-neededWe allow the
AuthorizationProviderinterface itself to be the documentation, so I do not see any need to update docs.Matching PR in forked repository
Since I already tested the compilation of the project, I see no reason to build in my own fork.