[fix][broker] Fix race condition while updating partition number#19199
Merged
mattisonchao merged 1 commit intoapache:masterfrom Jan 12, 2023
mattisonchao:fix_race_condition
Merged
[fix][broker] Fix race condition while updating partition number#19199mattisonchao merged 1 commit intoapache:masterfrom mattisonchao:fix_race_condition
mattisonchao merged 1 commit intoapache:masterfrom
mattisonchao:fix_race_condition
Conversation
mattisonchao
added
type/bug
Codecov Report
@@ Coverage Diff @@
## master #19199 +/- ##
============================================
+ Coverage 45.64% 45.91% +0.27%
+ Complexity 11043 10406 -637
============================================
Files 773 713 -60
Lines 74463 69728 -4735
Branches 8018 7495 -523
============================================
- Hits 33986 32017 -1969
+ Misses 36687 34021 -2666
+ Partials 3790 3690 -100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AnonHxy
approved these changes
Jan 12, 2023
Contributor
|
LGTM |
cbornet
approved these changes
Jan 12, 2023
liangyepianzhou
pushed a commit
that referenced
this pull request
Feb 10, 2023
) (cherry picked from commit 4d57828)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2023
…che#19199) (cherry picked from commit 4d57828) (cherry picked from commit 4b83d06)
coderzc
pushed a commit
to coderzc/pulsar
that referenced
this pull request
Mar 2, 2023
…che#19199) (cherry picked from commit 4d57828)
4 tasks
coderzc
added a commit
that referenced
this pull request
Mar 3, 2023
Technoboy-
added a commit
that referenced
this pull request
Mar 6, 2023
Annavar-satish
pushed a commit
to pandio-com/pulsar
that referenced
this pull request
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We use
latestto copy subscriptions from another topic; there is a gap between the topic creation and subscription. In this period, If some new producer sends messages to the new topic partition. There may look like some messages are lost on the user side.Because there is a new topic partition, I think it's Ok to change
latesttoearliest.Modifications
earliestinstead oflatest.Verifying this change
It's hard to add the test case.
Documentation
docdoc-requireddoc-not-neededdoc-complete