[fix][fn] Fix TLS configuration for fn worker to broker if auth disabled #19290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
requested review from
eolivelli,
lhotari and
michaeljmarshall
and removed request for
eolivelli and
michaeljmarshall
Member
|
/pulsarbot rerun-failure-checks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Regression of #11681
In case of standalone functions worker, the pulsar client connected to the broker doesn't pick up the
brokerClientTrustCertsFilePathconfiguration if authentication is disabled.This causes issues if
TlsEnableHostnameVerification=trueand the certificate is self signed.I don't think is much critical since non authenticated clusters are very rare when tls is enabled.
Modifications
brokerClientTrustCertsFilePathoption if auth is disabledDocumentation
docdoc-requireddoc-not-neededdoc-complete