[fix][test] Fix flaky MetadataStoreStatsTest and prevent certain flakiness in all metric / stat tests #19329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
requested review from
Technoboy-,
cbornet,
eolivelli,
nicoloboschi and
tisonkun
2 tasks
nicoloboschi
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18300
Motivation
MetadataStoreStatsTest is very flaky and it causes a lot of builds to fail.
The main reason for the flakiness was the asynchronous broker shutdown.
Modifications
The solution was to set
brokerShutdownTimeoutMsto5000to prevent the issue wherea metric is unregistered asynchronously while the next method is executing.
There's also a change to log the metrics together with the asserts in MetadataStoreStatsTest. This will help investigate any possible future issues if any remain.
Documentation
docdoc-requireddoc-not-neededdoc-complete