[fix][client] Fix async completion in ConsumerImpl#processPossibleToDLQ#19392
Merged
lhotari merged 1 commit intoapache:masterfrom Feb 2, 2023
Merged
Conversation
- the possible failure of acknowledging the message isn't handled
lhotari
added
type/bug
lhotari
requested review from
Technoboy-,
codelipenghui,
eolivelli,
mattisonchao,
merlimat,
michaeljmarshall and
nicoloboschi
nicoloboschi
approved these changes
Feb 2, 2023
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2023
…LQ (apache#19392) (cherry picked from commit 39dd1cd) (cherry picked from commit 73f6693)
Annavar-satish
pushed a commit
to pandio-com/pulsar
that referenced
this pull request
Mar 6, 2023
…LQ (apache#19392) (cherry picked from commit 39dd1cd)
Technoboy-
pushed a commit
that referenced
this pull request
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
exceptionallyhandler in the code below this particular location doesn't get executed, since it's in a different call chain than theacknowledgeAsynccall. Perhaps that was the author's expectation that the failure would be handled by theexceptionallyhandler.Modifications
falsewhen there are failures.Documentation
docdoc-requireddoc-not-neededdoc-complete