Skip to content

[improve] [broker] Print warn log if compaction failure#19405

Merged
Technoboy- merged 1 commit intoapache:masterfrom
poorbarcode:improve/compaction_log
Feb 4, 2023
Merged

[improve] [broker] Print warn log if compaction failure#19405
Technoboy- merged 1 commit intoapache:masterfrom
poorbarcode:improve/compaction_log

Conversation

@poorbarcode
Copy link
Copy Markdown
Contributor

Motivation

Now exceptions that happen in the flow of compaction task are collected into variable currentCompaction and don't print any log.

When compaction doesn't work, two reasons come to mind:

  • the task skipped by rules.
  • the task failed.

We can't determine which causing the problem if there has no log, this increases the difficulty of troubleshooting.

The API pulsar-admin topics compaction-status <topic> lets us see what happens when the last compaction executes, But it can not help us know if there were previous missions that failed.

Modifications

Print warn log if compaction fails.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Feb 2, 2023
@dave2wave dave2wave requested a review from dlg99 February 2, 2023 16:33
@Technoboy- Technoboy- added this to the 3.0.0 milestone Feb 3, 2023
@Technoboy- Technoboy- closed this Feb 3, 2023
@Technoboy- Technoboy- reopened this Feb 3, 2023
@poorbarcode
Copy link
Copy Markdown
Contributor Author

/pulsarbot rerun-failure-checks

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 4, 2023

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.59%. Comparing base (39dd1cd) to head (6cb2ff6).
⚠️ Report is 2891 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19405       +/-   ##
=============================================
+ Coverage     32.36%   62.59%   +30.22%     
- Complexity     6355    25663    +19308     
=============================================
  Files          1648     1830      +182     
  Lines        123990   133944     +9954     
  Branches      13523    14737     +1214     
=============================================
+ Hits          40129    83838    +43709     
+ Misses        77958    42381    -35577     
- Partials       5903     7725     +1822     
Flag Coverage Δ
inttests 24.88% <0.00%> (+0.07%) ⬆️
systests 25.58% <0.00%> (-0.11%) ⬇️
unittests 59.78% <100.00%> (+42.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...sar/broker/service/persistent/PersistentTopic.java 64.30% <100.00%> (+13.02%) ⬆️

... and 1230 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants