[improve] [broker] Print warn log if compaction failure#19405
Merged
Technoboy- merged 1 commit intoapache:masterfrom Feb 4, 2023
Merged
[improve] [broker] Print warn log if compaction failure#19405Technoboy- merged 1 commit intoapache:masterfrom
Technoboy- merged 1 commit intoapache:masterfrom
Conversation
Technoboy-
approved these changes
Feb 3, 2023
Contributor
Author
|
/pulsarbot rerun-failure-checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19405 +/- ##
=============================================
+ Coverage 32.36% 62.59% +30.22%
- Complexity 6355 25663 +19308
=============================================
Files 1648 1830 +182
Lines 123990 133944 +9954
Branches 13523 14737 +1214
=============================================
+ Hits 40129 83838 +43709
+ Misses 77958 42381 -35577
- Partials 5903 7725 +1822
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
poorbarcode
added a commit
that referenced
this pull request
Jul 27, 2023
(cherry picked from commit 5b32220)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Now exceptions that happen in the flow of compaction task are collected into variable
currentCompactionand don't print any log.When compaction doesn't work, two reasons come to mind:
We can't determine which causing the problem if there has no log, this increases the difficulty of troubleshooting.
The API
pulsar-admin topics compaction-status <topic>lets us see what happens when the last compaction executes, But it can not help us know if there were previous missions that failed.Modifications
Print warn log if compaction fails.
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: