[fix][ml] Fix potential NPE cause future never complete.#19415
Merged
lhotari merged 1 commit intoapache:masterfrom Feb 3, 2023
mattisonchao:fix/potential/npe
Merged
[fix][ml] Fix potential NPE cause future never complete.#19415lhotari merged 1 commit intoapache:masterfrom mattisonchao:fix/potential/npe
lhotari merged 1 commit intoapache:masterfrom
mattisonchao:fix/potential/npe
Conversation
lhotari
approved these changes
Feb 3, 2023
Member
|
/pulsarbot rerun-failure-checks |
HQebupt
approved these changes
Feb 3, 2023
Codecov Report
@@ Coverage Diff @@
## master #19415 +/- ##
=============================================
+ Coverage 27.22% 62.46% +35.23%
- Complexity 6264 25682 +19418
=============================================
Files 1644 1829 +185
Lines 123745 134865 +11120
Branches 13495 14985 +1490
=============================================
+ Hits 33693 84245 +50552
+ Misses 84932 42901 -42031
- Partials 5120 7719 +2599
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Technoboy-
approved these changes
Feb 3, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
liangyepianzhou
pushed a commit
that referenced
this pull request
Feb 9, 2023
(cherry picked from commit 11073fd)
coderzc
pushed a commit
that referenced
this pull request
Feb 27, 2023
(cherry picked from commit 11073fd)
Annavar-satish
pushed a commit
to pandio-com/pulsar
that referenced
this pull request
Mar 6, 2023
(cherry picked from commit 11073fd)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Found by chance :)
I wonder if it is a real problem, but we judged it in the previous lines. I think the
ex.getCauseprobably is null.Modifications
Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: