[fix][ml] Reset individualDeletedMessagesSerializedSize after acked all messages.#19428
Merged
Technoboy- merged 1 commit intoapache:masterfrom Feb 5, 2023
mattisonchao:fix/stats/individualDeletedMessagesSerializedSize
Merged
[fix][ml] Reset individualDeletedMessagesSerializedSize after acked all messages.#19428Technoboy- merged 1 commit intoapache:masterfrom mattisonchao:fix/stats/individualDeletedMessagesSerializedSize
Technoboy- merged 1 commit intoapache:masterfrom
mattisonchao:fix/stats/individualDeletedMessagesSerializedSize
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19428 +/- ##
=============================================
+ Coverage 27.22% 64.01% +36.78%
- Complexity 6264 26135 +19871
=============================================
Files 1644 1831 +187
Lines 123745 133979 +10234
Branches 13495 14741 +1246
=============================================
+ Hits 33693 85766 +52073
+ Misses 84932 40397 -44535
- Partials 5120 7816 +2696
Flags with carried forward coverage won't be shown. Click here to find out more.
|
merlimat
approved these changes
Feb 4, 2023
Technoboy-
approved these changes
Feb 5, 2023
Technoboy-
pushed a commit
that referenced
this pull request
Feb 8, 2023
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Feb 28, 2023
…ll messages. (apache#19428) (cherry picked from commit c91303d) (cherry picked from commit 0c7b250)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We should reset
individualDeletedMessagesSerializedSizeif all the message is acknowledged. (no more individualDeletedMessages)Modifications
individualDeletedMessagesSerializedSize=0when theindividualDeletedMessages.isEmpty()Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete