Skip to content

[fix][ml] Reset individualDeletedMessagesSerializedSize after acked all messages.#19428

Merged
Technoboy- merged 1 commit intoapache:masterfrom
mattisonchao:fix/stats/individualDeletedMessagesSerializedSize
Feb 5, 2023
Merged

[fix][ml] Reset individualDeletedMessagesSerializedSize after acked all messages.#19428
Technoboy- merged 1 commit intoapache:masterfrom
mattisonchao:fix/stats/individualDeletedMessagesSerializedSize

Conversation

@mattisonchao
Copy link
Copy Markdown
Member

Motivation

We should reset individualDeletedMessagesSerializedSize if all the message is acknowledged. (no more individualDeletedMessages)

Modifications

  • Reset individualDeletedMessagesSerializedSize=0 when the individualDeletedMessages.isEmpty()

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao self-assigned this Feb 4, 2023
@mattisonchao mattisonchao added this to the 3.0.0 milestone Feb 4, 2023
@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Feb 4, 2023
@mattisonchao mattisonchao reopened this Feb 4, 2023
@mattisonchao mattisonchao changed the title [fix] Reset individualDeletedMessagesSerializedSize after acked all messages. [fix][broker] Reset individualDeletedMessagesSerializedSize after acked all messages. Feb 4, 2023
@mattisonchao mattisonchao changed the title [fix][broker] Reset individualDeletedMessagesSerializedSize after acked all messages. [fix][ml] Reset individualDeletedMessagesSerializedSize after acked all messages. Feb 4, 2023
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #19428 (8066be8) into master (3d8b52a) will increase coverage by 36.78%.
The diff coverage is 33.48%.

Impacted file tree graph

@@              Coverage Diff              @@
##             master   #19428       +/-   ##
=============================================
+ Coverage     27.22%   64.01%   +36.78%     
- Complexity     6264    26135    +19871     
=============================================
  Files          1644     1831      +187     
  Lines        123745   133979    +10234     
  Branches      13495    14741     +1246     
=============================================
+ Hits          33693    85766    +52073     
+ Misses        84932    40397    -44535     
- Partials       5120     7816     +2696     
Flag Coverage Δ
inttests 24.87% <17.23%> (?)
systests 25.48% <10.85%> (-0.02%) ⬇️
unittests 61.24% <31.44%> (+43.68%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ker/loadbalance/extensions/BrokerRegistryImpl.java 0.00% <0.00%> (ø)
...xtensions/channel/ServiceUnitStateChannelImpl.java 0.96% <0.00%> (+0.96%) ⬆️
...balance/extensions/store/LoadDataStoreFactory.java 0.00% <0.00%> (ø)
...e/extensions/store/TableViewLoadDataStoreImpl.java 0.00% <0.00%> (ø)
.../apache/pulsar/client/api/MessageAcknowledger.java 0.00% <ø> (ø)
...rg/apache/pulsar/client/impl/PulsarClientImpl.java 73.91% <ø> (+25.13%) ⬆️
...ent/impl/UnAckedTopicMessageRedeliveryTracker.java 7.14% <0.00%> (+7.14%) ⬆️
...pulsar/client/impl/UnAckedTopicMessageTracker.java 43.75% <0.00%> (+31.25%) ⬆️
...che/pulsar/io/elasticsearch/client/RestClient.java 84.69% <ø> (+84.69%) ⬆️
...n/coordinator/impl/MLTransactionMetadataStore.java 75.64% <ø> (+75.64%) ⬆️
... and 1355 more

@Technoboy- Technoboy- merged commit c91303d into apache:master Feb 5, 2023
Technoboy- pushed a commit that referenced this pull request Feb 8, 2023
liangyepianzhou pushed a commit that referenced this pull request Feb 10, 2023
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Feb 28, 2023
…ll messages. (apache#19428)

(cherry picked from commit c91303d)
(cherry picked from commit 0c7b250)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants