Skip to content

Conversation

@horizonzy
Copy link
Member

@horizonzy horizonzy commented Feb 7, 2023

Master Issue: #xyz

PIP: #xyz

Motivation

In #13025,
In bkenv.sh, it move BOOKIE_MEM, BOOKIE_GC out from BOOKIE_EXTRA_OPTS.
In bin/bookkeeper, use OPTS="$OPTS $BOOKIE_MEM $BOOKIE_GC $BOOKIE_GC_LOG $BOOKIE_EXTRA_OPTS".
So it works.

In 1fa9e1e, it cherry-pick to branch-2.9.
It miss the #13025, and remove BOOKIE_MEM, BOOKIE_GC. So, the param BOOKIE_MEM, BOOKIE_GC were missed.

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@horizonzy horizonzy changed the title [Branch-2.19] Fix bookie JVM param BOOKIE_MEM, BOOKIE_GC miss problem. [fix][Branch-2.19] Fix bookie JVM param BOOKIE_MEM, BOOKIE_GC miss problem. Feb 7, 2023
@horizonzy horizonzy changed the title [fix][Branch-2.19] Fix bookie JVM param BOOKIE_MEM, BOOKIE_GC miss problem. [fix][Branch-2.9] Fix bookie JVM param BOOKIE_MEM, BOOKIE_GC miss problem. Feb 7, 2023
@hangc0276 hangc0276 added the type/bug The PR fixed a bug or issue reported a bug label Feb 7, 2023
@hangc0276
Copy link
Contributor

#13563 tagged with 2.8.5, when we cherry-pick it into branch-2.8, we also need to cherry-pick this PR, otherwise, the bookie couldn't apply the memory and GC configurations.

@Technoboy- Technoboy- merged commit 313aa11 into apache:branch-2.9 Feb 17, 2023
@coderzc coderzc added the cherry-picked/branch-2.9 Archived: 2.9 is end of life label Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked/branch-2.9 Archived: 2.9 is end of life release/2.8.5 release/2.9.5 type/bug The PR fixed a bug or issue reported a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants