[fix][fn] Fix k8s merge runtime opts bug

[michaeljmarshall]

Fixes: #19478

Motivation

See issue for additional context. Essentially, we are doing a shallow clone when we needed a deep clone. The consequence is leaked labels, annotations, and tolerations.

Modifications

• Add a deepClone method to the BasicKubernetesManifestCustomizer.RuntimeOpts method. Note that this method is not technically a deep clone for the k8s objects. However, based on the way we "merge" these objects, it is sufficient to copy references to the objects.

Verifying this change

Added a test that fails before the change and passes afterwards.

Documentation

• doc-not-needed

This is an internal bug fix. No docs needed.

Matching PR in forked repository

PR in forked repository: michaeljmarshall#27

[lhotari]

Good catch

[lhotari]

/pulsarbot rerun-failure-checks

[codecov-commenter]

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.89%. Comparing base (016e7f0) to head (4c39986).
⚠️ Report is 2858 commits behind head on master.

Files with missing lines	Patch %	Lines
.../kubernetes/BasicKubernetesManifestCustomizer.java	87.50%	1 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             master   #19481       +/-   ##
=============================================
+ Coverage     24.75%   63.89%   +39.13%     
- Complexity      288    26098    +25810     
=============================================
  Files          1579     1832      +253     
  Lines        121841   134149    +12308     
  Branches      13304    14760     +1456     
=============================================
+ Hits          30164    85710    +55546     
+ Misses        87240    40624    -46616     
- Partials       4437     7815     +3378     

Flag	Coverage Δ
inttests	24.87% <0.00%> (+0.12%)	⬆️
systests	25.40% <0.00%> (?)
unittests	61.16% <87.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
.../kubernetes/BasicKubernetesManifestCustomizer.java	80.99% <87.50%> (+80.99%)	⬆️

... and 1410 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.