[fix][broker] Make ServerCnx#originalAuthData volatile#19507
Merged
michaeljmarshall merged 1 commit intoapache:masterfrom Feb 14, 2023
Merged
[fix][broker] Make ServerCnx#originalAuthData volatile#19507michaeljmarshall merged 1 commit intoapache:masterfrom
michaeljmarshall merged 1 commit intoapache:masterfrom
Conversation
michaeljmarshall
added
area/broker
doc-not-needed
codelipenghui
approved these changes
Feb 14, 2023
nodece
approved these changes
Feb 14, 2023
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19507 +/- ##
=============================================
+ Coverage 24.75% 62.25% +37.49%
- Complexity 288 25744 +25456
=============================================
Files 1579 1843 +264
Lines 121841 135158 +13317
Branches 13304 14856 +1552
=============================================
+ Hits 30164 84138 +53974
+ Misses 87240 43285 -43955
- Partials 4437 7735 +3298
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
michaeljmarshall
added a commit
that referenced
this pull request
Feb 14, 2023
Fixes #19431 `authenticationData` is already `volatile`. We use `originalAuthData` when set, so we should match the style. In #19431, I proposed that we find a way to not use `volatile`. I still think this might be a "better" approach, but it will be a larger change, and since we already use `volatile` for `authenticationData`, I think this is the right change for now. It's possible that this is not a bug, given that the `originalAuthData` does not change frequently. However, we always want to use up to date values for authorization. * Add `volatile` keyword to `ServerCnx#originalAuthData`. This change is a trivial rework / code cleanup without any test coverage. - [x] `doc-not-needed` PR in forked repository: skipping test in fork. (cherry picked from commit c4c1744)
michaeljmarshall
added a commit
to datastax/pulsar
that referenced
this pull request
Feb 14, 2023
Fixes apache#19431 `authenticationData` is already `volatile`. We use `originalAuthData` when set, so we should match the style. In apache#19431, I proposed that we find a way to not use `volatile`. I still think this might be a "better" approach, but it will be a larger change, and since we already use `volatile` for `authenticationData`, I think this is the right change for now. It's possible that this is not a bug, given that the `originalAuthData` does not change frequently. However, we always want to use up to date values for authorization. * Add `volatile` keyword to `ServerCnx#originalAuthData`. This change is a trivial rework / code cleanup without any test coverage. - [x] `doc-not-needed` PR in forked repository: skipping test in fork. (cherry picked from commit c4c1744) (cherry picked from commit e1d9941)
michaeljmarshall
added a commit
that referenced
this pull request
Feb 14, 2023
Fixes #19431 `authenticationData` is already `volatile`. We use `originalAuthData` when set, so we should match the style. In #19431, I proposed that we find a way to not use `volatile`. I still think this might be a "better" approach, but it will be a larger change, and since we already use `volatile` for `authenticationData`, I think this is the right change for now. It's possible that this is not a bug, given that the `originalAuthData` does not change frequently. However, we always want to use up to date values for authorization. * Add `volatile` keyword to `ServerCnx#originalAuthData`. This change is a trivial rework / code cleanup without any test coverage. - [x] `doc-not-needed` PR in forked repository: skipping test in fork. (cherry picked from commit c4c1744) (cherry picked from commit e1d9941)
michaeljmarshall
added a commit
that referenced
this pull request
Feb 14, 2023
Fixes #19431 `authenticationData` is already `volatile`. We use `originalAuthData` when set, so we should match the style. In #19431, I proposed that we find a way to not use `volatile`. I still think this might be a "better" approach, but it will be a larger change, and since we already use `volatile` for `authenticationData`, I think this is the right change for now. It's possible that this is not a bug, given that the `originalAuthData` does not change frequently. However, we always want to use up to date values for authorization. * Add `volatile` keyword to `ServerCnx#originalAuthData`. This change is a trivial rework / code cleanup without any test coverage. - [x] `doc-not-needed` PR in forked repository: skipping test in fork. (cherry picked from commit c4c1744) (cherry picked from commit e1d9941)
michaeljmarshall
added a commit
that referenced
this pull request
Feb 14, 2023
Fixes #19431 `authenticationData` is already `volatile`. We use `originalAuthData` when set, so we should match the style. In #19431, I proposed that we find a way to not use `volatile`. I still think this might be a "better" approach, but it will be a larger change, and since we already use `volatile` for `authenticationData`, I think this is the right change for now. It's possible that this is not a bug, given that the `originalAuthData` does not change frequently. However, we always want to use up to date values for authorization. * Add `volatile` keyword to `ServerCnx#originalAuthData`. This change is a trivial rework / code cleanup without any test coverage. - [x] `doc-not-needed` PR in forked repository: skipping test in fork. (cherry picked from commit c4c1744) (cherry picked from commit e1d9941) (cherry picked from commit f8de0fb)
michaeljmarshall
added
cherry-picked/branch-2.8
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19431
Motivation
authenticationDatais alreadyvolatile. We useoriginalAuthDatawhen set, so we should match the style. In #19431, I proposed that we find a way to not usevolatile. I still think this might be a "better" approach, but it will be a larger change, and since we already usevolatileforauthenticationData, I think this is the right change for now.It's possible that this is not a bug, given that the
originalAuthDatadoes not change frequently. However, we always want to use up to date values for authorization.Modifications
volatilekeyword toServerCnx#originalAuthData.Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository: skipping test in fork.