-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix][test] ProxyWithAuthorizationTest remove SAN from test certs #19594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][test] ProxyWithAuthorizationTest remove SAN from test certs #19594
Conversation
|
@nicoloboschi is this related to your latest PR? |
I don't think so. The issues were created a lot of times before that regression |
…ache#19594) (cherry picked from commit f292bad) (cherry picked from commit 6576231) (cherry picked from commit 14152fc)
…ache#19594) (cherry picked from commit f292bad) (cherry picked from commit 6576231) (cherry picked from commit 14152fc)
…ache#19594) (cherry picked from commit f292bad) (cherry picked from commit 6576231) (cherry picked from commit 14152fc) (cherry picked from commit fbf4c17)
…ache#19594) (cherry picked from commit f292bad) (cherry picked from commit 6576231) (cherry picked from commit 14152fc) (cherry picked from commit fbf4c17)
|
In talking with @lhotari offline, this PR's motivation might not have been clearly explained. Here is my justification: The tests that I updated to use the certs without subject alternative names are tests that ensure the client does not connect to a proxy/broker when the cert fails hostname verification. When |
…erts (apache#19594)" This reverts commit 14152fc.
Fixes #19175 #19587
Motivation
In #15824, we added the subject alternative name to the certs for some tests. This is problematic for some tests that were expecting hostname verification to fail due to missing SANs. This PR adds a new cert without the SANs to ensure correct coverage.
One nuance is that I updated my
/etc/ssl/openssl.cnffile to include the following config:I also had trouble with the
-textoutput (not sure why), so I updated how the certs are written to files. That is likely dependent on the version of openssl.Modifications
ProxyWithAuthorizationTestto ensure correct test coverageVerifying this change
This is a test fix.
Documentation
docThis change includes updates to relevant comments for internal testing documentation.
Matching PR in forked repository
PR in forked repository: skipping because tests pass locally