Skip to content

[branch-2.10][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914) #19640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liangyepianzhou wants to merge 4 commits into from
Closed

[branch-2.10][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914) #19640

liangyepianzhou wants to merge 4 commits into from

Conversation

@liangyepianzhou
Copy link
Contributor

@liangyepianzhou liangyepianzhou commented Feb 26, 2023

Motivation

Cherry-pick #15914

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@dlg99 @liangyepianzhou
[Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Dele…
6706c4b 
…tion (#15914)

* Truncate topic before deletion to avoid orphaned offloaded ledgers

* CR feedback

(cherry picked from commit 9026d19)
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Feb 26, 2023
@liangyepianzhou liangyepianzhou changed the title [Fix][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914) [branch-2.10][Tiered Storage] Eagerly Delete Offloaded Segments On Topic Deletion (#15914) Feb 26, 2023
eolivelli
eolivelli requested changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change cannot go into 2.10.

It is a breaking change.

@liangyepianzhou liangyepianzhou deleted the xiangying/cherry-pick-2.10/tired_storage branch February 28, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eolivelli eolivelli eolivelli requested changes

Assignees

No one assigned

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@liangyepianzhou @eolivelli @dlg99