[fix][broker] Filter system topic when getting topic list by binary proto. #19667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shibd
requested review from
BewareMyPower,
Technoboy-,
congbobo184 and
eolivelli
poorbarcode
reviewed
Mar 1, 2023
Contributor
There was a problem hiding this comment.
Hi @shibd
These system topics are defined by PIP-178. Could we only filter out these topics instead of all system topics?
Hi @liangyepianzhou
Could you review this PR?
Member
Author
Why? I think we should filter all system topics, these topics should be invisible to the user. |
poorbarcode
reviewed
Mar 2, 2023
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java
Show resolved
Hide resolved
eolivelli
approved these changes
Mar 2, 2023
Contributor
eolivelli
left a comment
eolivelli
left a comment
There was a problem hiding this comment.
+1
we should cherry pick this to branch-2.11
poorbarcode
approved these changes
Mar 2, 2023
Technoboy-
approved these changes
Mar 5, 2023
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Mar 6, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In v2.11.0, the system topic enables by default. This causes the
GET_TOPICS_OF_NAMESPACEcommand to return the system topic redundantly.And, If the transaction is enabled, the transaction-related system topic will return by the client(
__transaction_buffer_snapshot, __transaction_buffer_snapshot_segments, __transaction_buffer_snapshot_indexes). This PR filters some transaction-related topics, but these are missing.This causes some incompatibility issues: If consumers use pattern subscribe and the pattern is
/tenant/namespace/.*, it will subscribe to these system topics.Discuss mail: https://lists.apache.org/thread/qhm0zbfw0wfd1m5vj977w002qmkr5lt9
Modifications
Verifying this change
testBinaryProtoSubscribeAllTopicOfNamespacewill cover the don't subscribe system topic.Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: shibd#21