Skip to content

Conversation

@GerMoranBYON
Copy link
Contributor

@GerMoranBYON GerMoranBYON commented Mar 9, 2023

Fixes outstanding comments from #19432

Master Issue: #12944

Motivation

This PR addresses some of the outstanding comments on the original PR #19432

Credit to the author @merlimat.
Happy for this work to be disgarded if remaining items on that work through before this on, but if helps move the issue forward.

I also PR's the work back to the origin repo in case that is preferred over this route.

Modifications

Updated the poms to remove the push tags and profile additions.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository: #1

@github-actions
Copy link

github-actions bot commented Mar 9, 2023

@GerMoranOverstock Please add the following content to your PR description and select a checkbox:

- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->

@github-actions github-actions bot added doc-not-needed Your PR changes do not impact docs and removed doc-label-missing labels Mar 9, 2023
@GerMoranBYON GerMoranBYON changed the title Docker multi arch [fix][ci] Docker multi arch - Addresses PR comments from #19432 Mar 9, 2023
@GerMoranBYON GerMoranBYON changed the title [fix][ci] Docker multi arch - Addresses PR comments from #19432 [improve][ci] Docker multi arch - Addresses PR comments from #19432 Mar 9, 2023
@GerMoranBYON
Copy link
Contributor Author

@lhotari @tisonkun @nodece Given that ye have commented on #19432
Wondering if you this would progress the issue.

@tisonkun tisonkun self-requested a review March 21, 2023 08:23
@coderzc coderzc self-requested a review March 27, 2023 04:37
@tisonkun
Copy link
Member

It seems the original PR is active again. Closing...

@tisonkun tisonkun closed this Mar 28, 2023
@GerMoranBYON
Copy link
Contributor Author

It seems the original PR is active again. Closing...

Yeah glad to see, unfortunately I found getting the automation kicked off on the PR process quiet complex and wasn't sure if it was false positive or if I was missing something.
Thanks for taking the time to look at none the less.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants