-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Branch-2.11] Revert [improve][broker] Require authRole is proxyRole to set originalPrincipal(#19455) #19820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Branch-2.11] Revert [improve][broker] Require authRole is proxyRole to set originalPrincipal(#19455) #19820
Conversation
…alPrincipal (apache#19455)" This reverts commit c7eabc9.
nodece
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
We need to revert more commits related to this PR. |
michaeljmarshall
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to revert more commits related to this PR.
Even if the PMC decides that the right decision is to "revert this behavior change", we should not revert this whole commit. Only a few lines of code are actually under dispute.
| } else if (StringUtils.isNotBlank(originalPrincipal) | ||
| && !(allowNonProxyPrincipalsToBeEqual && originalPrincipal.equals(authenticatedPrincipal))) { | ||
| errorMsg = "cannot specify originalPrincipal when connecting without valid proxy role."; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the lines that are under question.
|
We have an acceptable solution for now. So that we don't need to revert this change, just push a fix to the release branches. And @michaeljmarshall message me in Slack, he will open PR to fix it. Thanks @hangc0276 and @michaeljmarshall |
|
#19830 should supersede this PR, so I am going to close this for now. |
This reverts commit c7eabc9.
Motivation
PR #19455 introduced break change and has been cherry-picked to release branch-2.11. It will lead to users upgrading to the new release version authenticate failed.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: