[improve][broker] Follow up #19230 to tighten the validation scope (#19234)#19839
Merged
mattisonchao merged 1 commit intoapache:branch-2.11from Mar 17, 2023
mattisonchao:cp/19234
Merged
[improve][broker] Follow up #19230 to tighten the validation scope (#19234)#19839mattisonchao merged 1 commit intoapache:branch-2.11from mattisonchao:cp/19234
mattisonchao merged 1 commit intoapache:branch-2.11from
mattisonchao:cp/19234
Conversation
…19234) ### Motivation This PR is following up #19230 As @yuruguo mentioned #19230 (comment), we can tighten the validation scope. I've checked the logic and found we have no way to create the partition topic with the `-partition-{index}` template. So we can righten the validation scope. I will keep working on the partition topic section and try to clarify the concept and logic. Plus, ensuring compatibility. ### Modifications - tighten the validation scope (cherry picked from commit 246c270)
|
@mattisonchao Please add the following content to your PR description and select a checkbox: |
github-actions
Bot
added
doc-not-needed
Technoboy-
approved these changes
Mar 17, 2023
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR is following up #19230
As @yuruguo mentioned #19230 (comment), we can tighten the validation scope.
I've checked the logic and found we have no way to create the partition topic with the
-partition-{index}template. So we can righten the validation scope.I will keep working on the partition topic section and try to clarify the concept and logic. Plus, ensuring compatibility.
Modifications
(cherry picked from commit 246c270)
doc-not-needed