[improve][txn] Cleanup how superusers abort txns#19976
Merged
michaeljmarshall merged 4 commits intoapache:masterfrom Apr 6, 2023
Merged
[improve][txn] Cleanup how superusers abort txns#19976michaeljmarshall merged 4 commits intoapache:masterfrom
michaeljmarshall merged 4 commits intoapache:masterfrom
Conversation
michaeljmarshall
added
area/transaction
doc-not-needed
Member
Author
|
/pulsarbot rerun-failure-checks |
nicoloboschi
approved these changes
Apr 3, 2023
Member
Author
|
@Technoboy- - I just discovered that this PR will fix a regression introduced by #19467. Once this is ready to go (hopefully today), I will cherry pick it to |
Contributor
Ok |
congbobo184
approved these changes
Apr 6, 2023
michaeljmarshall
added a commit
that referenced
this pull request
Apr 6, 2023
This PR builds on #19467. When we modify/abort transactions, we need to make sure that authorization is checked for both the proxy and the client. * Add a second authorization check when `originalPrincipal` is set in the `ServerCnx`. * Fix a bug where we were not doing a deep copy of the `SubscriptionsList` object. (Tests caught this bug!) Added a new test to cover some of the changes. This is an internal change. - [x] `doc-not-needed` PR in forked repository: michaeljmarshall#38 (cherry picked from commit f76beda)
Member
Author
|
I cherry picked to 2.11 and verified that some of the relevant tests pass. I will cherry pick to 2.10 tomorrow. There are some conflicts I need to work through. |
michaeljmarshall
added a commit
that referenced
this pull request
Apr 7, 2023
This PR builds on #19467. When we modify/abort transactions, we need to make sure that authorization is checked for both the proxy and the client. * Add a second authorization check when `originalPrincipal` is set in the `ServerCnx`. * Fix a bug where we were not doing a deep copy of the `SubscriptionsList` object. (Tests caught this bug!) Added a new test to cover some of the changes. This is an internal change. - [x] `doc-not-needed` PR in forked repository: michaeljmarshall#38 (cherry picked from commit f76beda) (cherry picked from commit 5a180f78d7636537198a758e1c9416e58d80bf42)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
May 11, 2023
This PR builds on apache#19467. When we modify/abort transactions, we need to make sure that authorization is checked for both the proxy and the client. * Add a second authorization check when `originalPrincipal` is set in the `ServerCnx`. * Fix a bug where we were not doing a deep copy of the `SubscriptionsList` object. (Tests caught this bug!) Added a new test to cover some of the changes. This is an internal change. - [x] `doc-not-needed` PR in forked repository: michaeljmarshall#38 (cherry picked from commit f76beda) (cherry picked from commit 5a180f78d7636537198a758e1c9416e58d80bf42) (cherry picked from commit 716db37)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR builds on #19467. When we modify/abort transactions, we need to make sure that authorization is checked for both the proxy and the client.
Modifications
originalPrincipalis set in theServerCnx.SubscriptionsListobject. (Tests caught this bug!)Verifying this change
Added a new test to cover some of the changes.
Does this pull request potentially affect one of the following parts:
This is an internal change.
Documentation
doc-not-neededMatching PR in forked repository
PR in forked repository: michaeljmarshall#38