[fix][build] Client modules should be built with Java 8

[tisonkun]

This fixes #19982.

Motivation

Client modules are promised to be compatible with Java 8.

Modifications

Add --releaase 8 for these two remaining client modules.

Verifying this change

Locally tested.

Before:

file target/classes/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.class
target/classes/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.class: compiled Java class data, version 61.0

After:

file target/classes/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.class 
target/classes/org/apache/pulsar/client/impl/auth/AuthenticationAthenz.class: compiled Java class data, version 52.0 (Java 1.8)

I don't know if we can add a CI step to ensure it.

Add enforce plugin to prevent regressions.

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

• Dependencies (add or upgrade a dependency)
• The public API
• The schema
• The default values of configurations
• The threading model
• The binary protocol
• The REST endpoints
• The admin CLI options
• The metrics
• Anything that affects deployment

Documentation

• doc
• doc-required
• doc-not-needed
• doc-complete

Matching PR in forked repository

PR in forked repository:

[eolivelli]

The broker modules should be compiled for jdk17

I agree that client must stay on 8.

[tisonkun]

Hi @lhotari & @eolivelli!

The changeset for updating the broker compiler version is for profile integration-test-java8. But I agree I can revert the change as it won't hurt.

[tisonkun]

Updated. Please give another look.

[lhotari]

LGTM

[codecov-commenter]

Codecov Report

Merging #19991 (29f99a8) into master (68c10ee) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #19991      +/-   ##
============================================
- Coverage     72.89%   72.82%   -0.08%     
+ Complexity    31619    31592      -27     
============================================
  Files          1861     1861              
  Lines        137356   137362       +6     
  Branches      15117    15118       +1     
============================================
- Hits         100131   100039      -92     
- Misses        29271    29366      +95     
- Partials       7954     7957       +3     

Flag	Coverage Δ
inttests	24.44% <ø> (+<0.01%)	⬆️
systests	25.00% <ø> (-0.04%)	⬇️
unittests	72.11% <ø> (-0.07%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 76 files with indirect coverage changes

[eolivelli]

Perfect

+1

[tisonkun]

Hi @Technoboy-! This can be a release blocker to 2.11.1. Since you're the RM for this release, I'd like to let you know this patch and ask if you can cherry-pick it to branch-2.11 and include it in 2.11.1.

[Technoboy-]

Hi @Technoboy-! This can be a release blocker to 2.11.1. Since you're the RM for this release, I'd like to let you know this patch and ask if you can cherry-pick it to branch-2.11 and include it in 2.11.1.

Thanks, cherry-picked to branch-2.11.